Skip to content

🧾Add share metadata#8069

Open
AndyScherzinger wants to merge 3 commits into
mainfrom
feat/noid/share-metadata
Open

🧾Add share metadata#8069
AndyScherzinger wants to merge 3 commits into
mainfrom
feat/noid/share-metadata

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Jun 16, 2026

Copy link
Copy Markdown
Member

Summary

While starting to work on #8052 (nowhere near completion..) to implement the sdhare review capability I realized that the share date always matched 1970 and digging and asking @grnd-alt it turned out deck shares have no creation and no last-edit date, like for example files/folder or tables shares. Yet for a share review app, that also stores a "review date" such timestamps are important to show a changed share for a re-review in case it changed. Hence creation and edit dates a crucial.

TODO

  • get CI to turn green 💚

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@AndyScherzinger AndyScherzinger force-pushed the feat/noid/share-metadata branch 8 times, most recently from af1f803 to 7e3e603 Compare June 19, 2026 19:31
@AndyScherzinger AndyScherzinger marked this pull request as ready for review June 19, 2026 19:46
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 19, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 19, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 19, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 19, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 19, 2026
Comment thread lib/Migration/AclTimestampBackfill.php Outdated
…s to deck_board_acl

Adds two integer columns (default 0) to track when a share was created
and last modified. A value of 0 is a magic sentinel meaning "unknown"
and covers all pre-existing shares.

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Records created_at on share insertion and updates last_modified_at on
every subsequent modification. The created_at value is preserved across
updates. Existing shares retain the 0 sentinel (unknown).

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants